Skip to content

Update CONTRIBUTING.md #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amacado merged 7 commits into from
Jun 30, 2021
Merged

Update CONTRIBUTING.md #694

amacado merged 7 commits into from
Jun 30, 2021

Conversation

@Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Jun 24, 2021

Contain:

  • Remove references about contributors having to optimize the SVGs manually
  • Update the requesting icon section

Panquesito7
Panquesito7 reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work, Thomas.

@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Jun 26, 2021

IMPORTANT

The latest commit also fixes #693, which renames the vueStorefront folder to vuestorefront. Git Bash somehow doesn't register the name change as a commitable change => I had to batch it in with other changes. Let's see if it works. If it doesn't, I'll figure out another way

@amacado amacado merged commit 1b018fb into develop Jun 30, 2021
@amacado
Copy link
Member

amacado commented Jun 30, 2021

@Thomas-Boi i assume the vuestorefront fix was not successful. I approve this request anyway to update the CONTRIBUTING.md.

@amacado amacado deleted the thomas/contributeUpdate branch June 30, 2021 09:41
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Thomas-Boi @Panquesito7 @amacado
Update CONTRIBUTING.md (devicons#694)
e30f040 
* Update CONTRIBUTING.md

* Apply suggestions from code review

Co-authored-by: David Leal <[email protected]>

* Update CONTRIBUTING

* Update folder name rule in CONTRIBUTING. Include vuestorefront fix

Co-authored-by: David Leal <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 left review comments

@amacado amacado amacado approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thomas-Boi @amacado @Panquesito7