Skip to content

Conversation

@tupaschoal
Copy link
Contributor

Closes #347

I got the icons directly from Atlassian's logo library and just tinkered them to the repo's standards

Here's a poor preview of each:
plain:
image
plain wordmark:
image
original:
image
original wordmark
image

@amacado amacado added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection labels Jun 30, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

There's something interesting happening with the jira-plain-wordmark icon. When I upload it to Icomoon, it works:
image

However, when the bot removes the color, the icon became the rectangle that you saw in the bot's result:
image

Icomoon also reports that it found the color white in the icon:
image

Can you try removing the white fill and recommit?

@tupaschoal
Copy link
Contributor Author

Can you try removing the white fill and recommit?

There was a shady invisible path layer hiding 🐱‍👤, I think I've dealt with it now.

@amacado amacado added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 30, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now! Thank you for the fix!

@Thomas-Boi Thomas-Boi merged commit 1cf1336 into devicons:develop Jul 1, 2021
@tupaschoal tupaschoal deleted the add-jira branch July 1, 2021 10:48
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants