Close #767 - convert strokes to fills for socketio SVGs #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
approved these changes
Aug 1, 2021
Member
Panquesito7
left a comment
Panquesito7
left a comment
There was a problem hiding this comment.
Nice. Great work, @Thomas-Boi; thanks! 😄👍🎉
Member
Author
|
I'll merge this PR in even without amacado's review. I think this doesn't warrant two reviewers since it's a SVG change. |
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
Co-authored-by: David Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #767.
I used Inkscape to convert the circles in the SVGs to paths. Generating the icons from these new versions yield proper result:
