Skip to content

Conversation

@thetutlage
Copy link
Contributor

Hello 👋

Submitting the icon for https://adonisjs.com

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Aug 1, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! The icon looks good. 👍
Please add a wordmark version as shown in their website.

image

@thetutlage
Copy link
Contributor Author

thetutlage commented Aug 2, 2021

Please add a wordmark version as shown in their website.

Sorry, I am not much into SVGs. But can you guide how to fit that wordmark logo into a "128 x 128" viewbox?

Edit: I gave it a try, please lemme know if it is good or the changed I am supposed to make :)

thetutlage and others added 2 commits August 6, 2021 09:14
Make is smaller and better as per the feedback in the original PR
@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for your contribution! 😄👍🎉

@Panquesito7 Panquesito7 changed the title new icon: adonisjs (original) new icon: adonisjs (original, original-wordmark) Aug 6, 2021
@Panquesito7 Panquesito7 merged commit 25a4580 into devicons:develop Aug 6, 2021
@thetutlage
Copy link
Contributor Author

Thanks for guiding and accepting the PR :)

@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* new icon: adonisjs (original)

* implement feedback

* add original wordmark icon

* Optimize svg

Make is smaller and better as per the feedback in the original PR

Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants