Skip to content

Conversation

@Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Dec 22, 2021

New feature section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format New Feature: a brief description of feature

This PR adds/fixes

Updated/add a couple features to the website:

Notes

@Alirezaaraby @Snailedlt @amacado please check out the PR and let me know if it addresses your problems.

@Panquesito7 Panquesito7 added the devops Devops/automation related enhancements label Dec 22, 2021
@Snailedlt
Copy link
Collaborator

I don't think I'll have time to look at this until next year. But without looking at the code, the bullet points look very promising :)

@Thomas-Boi Thomas-Boi added feature:icon PR when a new icon is ready to be added to the collection enhancement and removed feature:icon PR when a new icon is ready to be added to the collection labels Dec 22, 2021
@Alirezaaraby
Copy link

Good. The #968 solved but i didn't find any commit message pointed to #971.

@Thomas-Boi
Copy link
Member Author

Good. The #968 solved but i didn't find any commit message pointed to #971.

It's not included in its own commit. I included in with one of the other commits. If you check out the website through the last commit in the PR, you should see the "Place this in your header" section moved up above the icons themselves.

@amacado
Copy link
Member

amacado commented Jan 17, 2022

Thanks for picking those issues up @Thomas-Boi! I've looked at it and just have some minor improvements in #1024. When you like it you can accept it and merge it in this branch! 😄

@Thomas-Boi
Copy link
Member Author

@amacado let me know if you need anything else for this PR. I think this should be fine now.

@amacado amacado merged commit 7b06adf into develop Jan 28, 2022
@amacado amacado deleted the thomas/feature/websiteUpgrade branch January 28, 2022 07:49
@Thomas-Boi Thomas-Boi mentioned this pull request Mar 22, 2022
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Devops/automation related enhancements enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants