Implemention of ratchetFrom for plugin-gradle
#590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we could do code-coverage on all tests, including testkit integration tests)
Member
Author
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to say
ratchetFrom 'origin/master', and formatting will then be applied only on files which have changed since 'origin/master`, as per the spec in #511.I believe there is probably a big performance enhancement to be had by caching this:
spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/GitRatchet.java
Lines 65 to 66 in eac82d2
but probably best to ship the simplest correct thing first, and we can always optimize it in the future.
This one adds almost no public API besides the already agreed-upon spec in #511. I would love feedback on the implementation, but since it doesn't affect public API, there's not much to lose by shipping it as-is. So just because it's merged doesn't mean it isn't still open for discussion :)