Update iconv extension to be shared, so it can be disabled if necessary #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Mar 9, 2022
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Ah, I suppose this is reasonable 😅
Just one minor change (which I'm happy to make directly if you'd prefer). 👍
msierks-pcln
force-pushed
the
shared-iconv
branch
from
f6d1ab1 to
85143a1
Compare
Member
|
Nice, thanks! |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 10, 2022
Changes: - docker-library/php@7fcdbf3: Merge pull request docker-library/php#1262 from msierks-pcln/shared-iconv - docker-library/php@85143a1: Update iconv extension to be shared, so it can be disabled if necessary
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 10, 2022
Changes: - docker-library/php@399ed12: Merge pull request docker-library/php#1264 from msierks-pcln/alpine-gnu-libiconv - docker-library/php@b62fa33: Use gnu-libiconv for php iconv extension on alpine - docker-library/php@7fcdbf3: Merge pull request docker-library/php#1262 from msierks-pcln/shared-iconv - docker-library/php@85143a1: Update iconv extension to be shared, so it can be disabled if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiles the iconv extension as a shared object so it may be disabled if necessary.
Disabling this extension is desired when using symfony's polyfill-iconv library.