build: fix multi-node merge to read descriptor from result #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1519
While the merge from
imagetools createused the correct input descriptor that it asked from the registry, the call of the same function from multi-node build just made up a descriptor from the digest.What is weirder is that the mediatype that the previous code used, didn't really matter because requests have
Accept: */*passed. But at least for hub it looks like for OCI objects evenAccept: */*gives an error, while for the old objects, you don't need to pass the correct header(this is why the merge worked both for merging lists and images). Not sure if this is registry specific. I'm trying to find out what behavior is expected from the registry side in this case.@smira
Signed-off-by: Tonis Tiigi [email protected]