Skip to content

Reuse PolicyAuthorizationResult #43210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wtgodbe merged 1 commit into from
Aug 12, 2022
Merged

Reuse PolicyAuthorizationResult #43210

wtgodbe merged 1 commit into from
Aug 12, 2022

Conversation

@Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Aug 11, 2022

PolicyAuthorizationResult is immutable. It could be stored and reused to avoid allocation.

@Kahbazi Kahbazi requested a review from Tratcher as a code owner August 11, 2022 04:54
@ghost ghost added area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member labels Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Thanks for your PR, @Kahbazi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

davidfowl
davidfowl approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtgodbe wtgodbe merged commit 155ec01 into dotnet:main Aug 12, 2022
@ghost ghost added this to the 7.0-rc1 milestone Aug 12, 2022
@Kahbazi Kahbazi deleted the kahbazi/ReusePolicyAuthorizationResult branch August 12, 2022 20:40
@davidfowl davidfowl added the Perf label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

No one assigned

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member Perf

Projects

None yet

Milestone

7.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@Kahbazi @davidfowl @wtgodbe