HttpSys request header dictionary does not remove headers when Remove() is called

[singh733]

HttpSys request header dictionary does not remove headers when Remove() is called # 43230

Fixes # 43230

[ghost]

Thanks for your PR, @singh733. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[Tratcher]

Also I made the changes in .tt file (which automatically reflected in the generated file)

The auto generation is working? I thought it was broken/disabled years ago. #5869. How did you make it run?

[singh733]

Also I made the changes in .tt file (which automatically reflected in the generated file)

The auto generation is working? I thought it was broken/disabled years ago. #5869. How did you make it run?

By adding TextTemplatingFileGenerator in the Custom tool it works.

When we make any change and save it then the following pop up came. It automatically update the generated file

[ladeak]

Hi, I am looking at #45156 touching the same files.

To confirm the goal of this change: after this change _flag0 and _flag1 will indicate if the value of the header is read from the native memory or set by the user. When the user deletes the value, _flag0 and _flag1 would remain set, but an empty string would be returned?

[Tratcher]

Hi, I am looking at #45156 touching the same files.

To confirm the goal of this change: after this change _flag0 and _flag1 will indicate if the value of the header is read from the native memory or set by the user. When the user deletes the value, _flag0 and _flag1 would remain set, but an empty string would be returned?

A null value, but otherwise yes.

aspnetcore/src/Shared/HttpSys/RequestProcessing/RequestHeaders.Generated.cs

Lines 16 to 18 in 23b55b0

	// Tracks if individual fields have been read from native or set directly.
	// Once read or set, their presence in the collection is marked by if their StringValues is null or not.
	private UInt32 _flag0, _flag1;

[singh733]

@Tratcher I have done all the changes as Suggested. Please let me know if you need any change.

[Tratcher]

Thanks