Skip to content

Adding untyped JsonTypeInfo overloads #45593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brunolins16 merged 3 commits into from
Jan 9, 2023
Merged

Adding untyped JsonTypeInfo overloads #45593

brunolins16 merged 3 commits into from
Jan 9, 2023

Conversation

@brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Dec 14, 2022 •
edited
Loading

@ghost ghost added the area-runtime label Dec 14, 2022
@brunolins16 brunolins16 marked this pull request as ready for review January 5, 2023 23:26
@brunolins16 brunolins16 requested a review from a team January 5, 2023 23:27
This was referenced Jan 6, 2023
Merged
Merged
@brunolins16 brunolins16 added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jan 6, 2023
mitchdenny
mitchdenny approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on content of approve design approval and the test coverage.

@brunolins16 brunolins16 merged commit b7ee505 into dotnet:main Jan 9, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 9, 2023
@brunolins16 brunolins16 mentioned this pull request Jan 9, 2023
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl approved these changes

@mitchdenny mitchdenny mitchdenny approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

Adding Http(Request/Response) extension methods overloads accepting non-generic JsonTypeInfo

4 participants

@brunolins16 @davidfowl @mitchdenny @amcasey