Use IndexOfAnyValues in ForwardedHeadersMiddleware #47459
Merged
+35
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
BrennanConroy and
Tratcher
as code owners
ghost
added
JamesNK
approved these changes
Mar 28, 2023
Member
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
Looks good to me, assuming there isn't an index off by one error we're missing.
What is unit testing like in this area?
MihaZupan
approved these changes
Mar 28, 2023
Member
Author
Unit testing in this area is pretty good (as I learned while working on this and breaking tests 😄). Feedback addressed. |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #46484
Updates the logic in ForwardedHeadersMiddleware dealing with host/port and scheme characters.