This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add Span-based {Try}Parse methods to primitive types #13389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2017
tarekgh
reviewed
Aug 16, 2017
|
|
||
| public static bool TryParse(ReadOnlySpan<char> value, out bool result) | ||
| { | ||
| ReadOnlySpan<char> trueSpan = TrueLiteral.AsSpan(); |
Member
There was a problem hiding this comment.
TrueLiteral.AsSpan() [](start = 42, length = 20)
is this fast operation or should we cache this value in some static?
Member
There was a problem hiding this comment.
It is fast operation, and you cannot cache Span in a static even if you wanted to - Span cannot be assigned to static field.
jkotas
reviewed
Aug 16, 2017
src/mscorlib/shared/System/Byte.cs
Outdated
|
|
||
| private static byte Parse(String s, NumberStyles style, NumberFormatInfo info) | ||
| { | ||
| if (s == null) ThrowHelper.ThrowArgumentNullException(ExceptionArgument.s); |
Member
There was a problem hiding this comment.
Is there a reason why there is extra private wrapper method in some cases (like here) vs. the code is inlined in other cases, for example the equivalent change for short is:
public static short Parse(String s, NumberStyles style, IFormatProvider provider)
{
NumberFormatInfo.ValidateParseStyleInteger(style);
if (s == null) ThrowHelper.ThrowArgumentNullException(ExceptionArgument.s);
return Parse(s.AsSpan(), style, NumberFormatInfo.GetInstance(provider));
}
Member
Author
There was a problem hiding this comment.
No reason, other than when editing 12 types with a bazillion overloads, one can lose track of the pattern (especially when they're already inconsistent) :) I'll review and tweak where necessary.
Member
Author
There was a problem hiding this comment.
@jkotas, I pushed a commit to make these methods consistent across the primitive types.
Member
|
LGTM. |
Adds Parse and TryParse methods to Boolean, Byte, Double, Int16, Int32, Int64, SByte, Single, UInt16, UInt32, UInt64, and Decimal.
- Make delegation between overloads as consistent as possible across the primitive types: Boolean, SByte/Byte, Int16/UInt16, and Single/Double were doing it one way, whereas Decimal, Int32/UInt32, and Int64/UInt64 were doing it another way (most of this inconsistency was preexisting this PR, but my previous commit doubled-down on the inconsistency). Changed the former to be like the latter.
stephentoub
force-pushed
the
primitiveparsing
branch
from
1120203 to
3e1314f
Compare
jkotas
approved these changes
Aug 16, 2017
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Aug 16, 2017
…13389) * Add Span-based {Try}Parse methods to primitive types Adds Parse and TryParse methods to Boolean, Byte, Double, Int16, Int32, Int64, SByte, Single, UInt16, UInt32, UInt64, and Decimal. * Address PR feedback - Make delegation between overloads as consistent as possible across the primitive types: Boolean, SByte/Byte, Int16/UInt16, and Single/Double were doing it one way, whereas Decimal, Int32/UInt32, and Int64/UInt64 were doing it another way (most of this inconsistency was preexisting this PR, but my previous commit doubled-down on the inconsistency). Changed the former to be like the latter. Signed-off-by: dotnet-bot <[email protected]>
stephentoub
added a commit
to dotnet/corert
that referenced
this pull request
Aug 16, 2017
…13389) * Add Span-based {Try}Parse methods to primitive types Adds Parse and TryParse methods to Boolean, Byte, Double, Int16, Int32, Int64, SByte, Single, UInt16, UInt32, UInt64, and Decimal. * Address PR feedback - Make delegation between overloads as consistent as possible across the primitive types: Boolean, SByte/Byte, Int16/UInt16, and Single/Double were doing it one way, whereas Decimal, Int32/UInt32, and Int64/UInt64 were doing it another way (most of this inconsistency was preexisting this PR, but my previous commit doubled-down on the inconsistency). Changed the former to be like the latter. Signed-off-by: dotnet-bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Parse and TryParse methods to Boolean, Byte, Double, Int16, Int32, Int64, SByte, Single, UInt16, UInt32, UInt64, and Decimal.
Contributes to https://github.com/dotnet/corefx/issues/22403
cc: @jkotas, @KrzysztofCwalina, @tarekgh