This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove use of ByReference<T> in Memmove ABI #17889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new ref reassignment feature instead
stephentoub
approved these changes
May 5, 2018
Member
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
1 similar comment
Member
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
Member
|
@dotnet/dnceng Linux-musl CI leg is hanging with: |
Member
|
Created https://github.com/dotnet/core-eng/issues/3429 to investigate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #15947. Now that Roslyn's ref reassignment feature is available, we can use that rather than the earlier workaround of passing
ByReference<T>throughMemmove's internal ABI.On x64, there's no difference in the codegen between using
ByReference<T>vs. ref reassignment. On x86, this change results in an approx. 15% decrease in codegen size for theMemmovemethod, and there is a commensurate increase in throughput in my brief testing. This is expected, as we knew during the original change that RyuJIT x86 doesn't quite optimize passingByReference<T>around as well as its x64 counterpart does.