This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Inline Span.CopyTo #18006
Merged
Inline Span.CopyTo #18006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems reasonable... in my experiments it looks like it reduces code size, both for value and ref type Ts (the latter when all is inlined into a non-shared method so T is known -- for shared root methods most inlines are blocked anyways because of shared/shared limitations). |
Member
|
@dotnet-bot test this please |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
May 30, 2018
Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
May 31, 2018
Signed-off-by: dotnet-bot <[email protected]>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jun 10, 2018
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Anipik
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jun 10, 2018
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dotnet/coreclr/issues/18005