This repository was archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
JIT: retrieve element class for arrays of ref types #20292
Merged
AndyAyersMS
merged 1 commit into
dotnet:master
from
AndyAyersMS:RecoverArrayElementClass
Oct 8, 2018
Merged
JIT: retrieve element class for arrays of ref types #20292
AndyAyersMS
merged 1 commit into
dotnet:master
from
AndyAyersMS:RecoverArrayElementClass
Oct 8, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows element-typed based optimizations for some array cases, say virtual calls through a `string[]`.
Member
Author
|
@erozenfeld PTAL Contributes to #9908. A few hits in jit pmi diffs (again just a partial corelib because of #20284) |
erozenfeld
reviewed
Oct 8, 2018
| objClass = lvaTable[objLcl].lvClassHnd; | ||
| *isExact = lvaTable[objLcl].lvClassIsExact; | ||
| } | ||
| else if (base->OperGet() == GT_ARR_ELEM) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation of the else is off.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like it's a bug in GitHub diff viewer. It's not showing several lines that I see in the raw file.
erozenfeld
approved these changes
Oct 8, 2018
Member
erozenfeld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
cc @brianrob tracecontrol failures for arm32 Ubuntu test runs |
A-And
pushed a commit
to A-And/coreclr
that referenced
this pull request
Nov 20, 2018
Allows element-typed based optimizations for some array cases, say virtual calls through a `string[]`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Allows element-typed based optimizations for some array cases, say
virtual calls through a
string[].