This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove remaining String.ToLower() use from corelib #26602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also happens to save a string allocation, but that's a drop in the bucket in this function.
filipnavara
approved these changes
Sep 9, 2019
jkotas
approved these changes
Sep 9, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Sep 10, 2019
Also happens to save a string allocation, but that's a drop in the bucket in this function. Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Sep 10, 2019
Also happens to save a string allocation, but that's a drop in the bucket in this function. Signed-off-by: dotnet-bot <[email protected]>
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Sep 10, 2019
Also happens to save a string allocation, but that's a drop in the bucket in this function. Signed-off-by: dotnet-bot <[email protected]>
stephentoub
added a commit
to dotnet/corefx
that referenced
this pull request
Sep 10, 2019
Also happens to save a string allocation, but that's a drop in the bucket in this function. Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Sep 12, 2019
Also happens to save a string allocation, but that's a drop in the bucket in this function. Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Sep 12, 2019
Also happens to save a string allocation, but that's a drop in the bucket in this function. Signed-off-by: dotnet-bot <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Also happens to save a string allocation, but that's a drop in the bucket in this function. Commit migrated from dotnet/coreclr@4432a27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be culture-specific.
Also happens to save a string allocation, but that's a drop in the bucket in this function.