Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Adding SkipInit to Internal.Runtime.CompilerServices.Unsafe #27377

Merged
jkotas merged 4 commits into from
Oct 23, 2019
Merged

Adding SkipInit to Internal.Runtime.CompilerServices.Unsafe #27377

jkotas merged 4 commits into from
Oct 23, 2019

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Oct 23, 2019

This exposes Internal.Runtime.CompilerServices.Unsafe.SkipInit and consumes it in Decimal.DecCalc. There were no pmi diffs from doing so.

@tannergooding
Copy link
Member Author

tannergooding commented Oct 23, 2019

CC. @jkotas.

Are there other known places that could switch to using Unsafe.SkipInit? From a quick search, there didn't seem to be any common pattern that could be used to easily identify said locations.

jkotas
jkotas reviewed Oct 23, 2019
View reviewed changes
@jkotas
Copy link
Member

jkotas commented Oct 23, 2019

Are there other known places that could switch to using Unsafe.SkipInit?

You have fixed all the ones that I am aware of.

jkotas
jkotas reviewed Oct 23, 2019
View reviewed changes
@jkotas jkotas merged commit 9bc350f into dotnet:master Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@stephentoub stephentoub stephentoub approved these changes

@jkotas jkotas jkotas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding @jkotas @stephentoub