Skip to content

Change option that enables/disables tier 0 JIT and expose another related option #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wli3 merged 3 commits into from
Apr 4, 2019
Merged

Change option that enables/disables tier 0 JIT and expose another related option #3064

wli3 merged 3 commits into from
Apr 4, 2019

Conversation

@kouvel
Copy link
Contributor

@kouvel kouvel commented Mar 30, 2019 •
edited
Loading

Depends on dotnet/coreclr#23597

  • Tier 0 JIT is being referred to as quick JIT. Renamed option that was added by Expose option to disable tier 0 JIT for configuring from a project file #2925 to TieredCompilationQuickJit, which indicates whether tiered compilation may use quick JIT in its startup tier. Default will be false.
  • May be enabled in .csproj under PropertyGroup element with <TieredCompilationQuickJit>true</TieredCompilationQuickJit>
  • Or in <app>.runtimeconfig.json with "System.Runtime.TieredCompilation.QuickJit": true

Change option that enables/disables tier 0 JIT and expose another rel…
ad268cd 
…ated option

Depends on dotnet/coreclr#23597

- Tier 0 JIT is being referred to as quick JIT. Renamed option that was added by #2925 to StartupTierQuickJit, which indicates whether tiered compilation may use quick JIT in its startup tier. Default will be false.
- Added option QuickJitForLoops that configures whether quick JIT may be used for methods that contain loops. Default will be false, so `<StartupTierQuickJit>true</StartupTierQuickJit>` would still not use quick JIT for methods that contain loops by default.
@kouvel
Copy link
Contributor Author

kouvel commented Mar 30, 2019 •
edited
Loading

CC @AndyAyersMS @noahfalk @nguerrera

I'd like to get this into preview 4, please let me know if I should port this to the 3.0.1xx branch. Also do changes that go into 3.0.1xx get mirrored automatically to master?

@kouvel
Copy link
Contributor Author

kouvel commented Mar 30, 2019

CC @jkotas @richlander

jkotas
jkotas reviewed Mar 30, 2019
View reviewed changes
@nguerrera
Copy link
Contributor

nguerrera commented Apr 1, 2019

I'd like to get this into preview 4, please let me know if I should port this to the 3.0.1xx branch

We haven't snapped for preview 4 from master yet, so this is fine.

@kouvel
Copy link
Contributor Author

kouvel commented Apr 1, 2019

Flagged with [WIP] in title due to dependency. Thanks @nguerrera, it may be a bit longer before this can be merged due to the dependency. I'll check with you again before merging to make sure it's going into the right branch for preview 4.

@kouvel kouvel changed the title Change option that enables/disables tier 0 JIT and expose another related option [WIP] Change option that enables/disables tier 0 JIT and expose another related option Apr 1, 2019
@nguerrera
Copy link
Contributor

nguerrera commented Apr 2, 2019

This needs to go in by Friday for Preview 4. After that, you will need M2 level approval in addition to changing the target branch.

@kouvel kouvel changed the title [WIP] Change option that enables/disables tier 0 JIT and expose another related option Change option that enables/disables tier 0 JIT and expose another related option Apr 3, 2019
@kouvel
Copy link
Contributor Author

kouvel commented Apr 3, 2019

Thanks for the heads-up @nguerrera, I'll try to get this in before then

@kouvel
Copy link
Contributor Author

kouvel commented Apr 4, 2019

Thanks @noahfalk. @nguerrera, I think this is ready to be merged but I don't have permissions to do so, would you be able to merge it?

@wli3 wli3 merged commit 45df784 into dotnet:master Apr 4, 2019
@wli3
Copy link

wli3 commented Apr 4, 2019

@nguerrera FYI i merged it

@kouvel kouvel deleted the QuickJitSdk branch April 4, 2019 21:42
@nguerrera
Copy link
Contributor

nguerrera commented Apr 5, 2019

Thank, @wli3

@richlander richlander mentioned this pull request Jan 31, 2020
Closed
wli3 pushed a commit that referenced this pull request Feb 7, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/core-setup build 2…
7e7477b 
…0191003.13 (#3064)

- Microsoft.NETCore.App - 5.0.0-alpha1.19503.13

Dependency coherency updates

- Microsoft.NET.Sdk.WindowsDesktop - 5.0.0-alpha1.19503.5 (parent: Microsoft.NETCore.App)
- System.CodeDom - 5.0.0-alpha1.19503.5 (parent: Microsoft.NETCore.App)
- System.Security.Cryptography.ProtectedData - 5.0.0-alpha1.19503.5 (parent: Microsoft.NETCore.App)
- System.Text.Encoding.CodePages - 5.0.0-alpha1.19503.5 (parent: Microsoft.NETCore.App)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas left review comments

@noahfalk noahfalk noahfalk approved these changes

+1 more reviewer

@nguerrera nguerrera nguerrera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kouvel @nguerrera @wli3 @noahfalk @jkotas