chore: bump node to v20.15.0 (main) #42616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
roller/node/main
branch
from
34f5f48 to
5e97f8c
Compare
codebytere
force-pushed
the
roller/node/main
branch
from
5e97f8c to
a43d7ea
Compare
codebytere
added
api-review/requested 🗳
and removed
semver/minor
ckerr
approved these changes
Jun 24, 2024
VerteDinde
approved these changes
Jun 24, 2024
| // V8::EnableWebAssemblyTrapHandler can be called only once or it will | ||
| // hard crash. We need to prevent Node.js calling it in the event it has | ||
| // already been called. | ||
| node::per_process::cli_options->disable_wasm_trap_handler = true; |
Member
There was a problem hiding this comment.
Should this be true or some kind of "is renderer" check as I assume the main process + utility process's don't have this set up?
Member
There was a problem hiding this comment.
Ah yeah we always want it - if you look at the diff you'll see it was true before but we patched it in as an env option before joyee merged a PR to accomplish the same goal
codebytere
force-pushed
the
roller/node/main
branch
from
18608f8 to
b135e29
Compare
codebytere
force-pushed
the
roller/node/main
branch
from
b135e29 to
a2a64e9
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Node.js to v20.15.0.
See all changes in v20.14.0..v20.15.0
Notes: Updated Node.js to v20.15.0.