Skip to content

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 13, 2016

According to this link the _Exit symbol is a valid alias for exit.
This PR adds it.

src/library.js Outdated
exit: function(status) {
__exit(status);
},
_Exit__deps: ['_exit'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can just be _Exit: 'exit', and the library system will map it.

@kripken
Copy link
Member

kripken commented Feb 13, 2016

Please add yourself to AUTHORS.

Also we should test this. Simplest is probably to make tests/test_core.py's test_exit_status check both exit and _Exit.

@tomaka
Copy link
Contributor Author

tomaka commented Feb 14, 2016

Done

kripken added a commit that referenced this pull request Feb 14, 2016
@kripken kripken merged commit 662dc86 into emscripten-core:incoming Feb 14, 2016
@kripken
Copy link
Member

kripken commented Feb 14, 2016

Thanks!

@tomaka tomaka deleted the exit-symbol branch February 14, 2016 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants