-
Notifications
You must be signed in to change notification settings - Fork 258
prepare release v0.5.0 #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this
2 remarks:
- I'm not sure it is fix anymore since sqlachemy was already pinned. IMO it's more a feature "support sqlachemy 1.4". WDYT?
- with this in mind should it be a 0.5.0 instead of a patched version since there is a breaking change?
Edit: sorry I'm on my phone travelling. Hard to type with those fat fingers
@PrettyWood I agree about the first point. |
|
I reckon it's easier to have 0.4 only for sqlachemy<=1.3 Having 0.4.3 for 1.3 and 0.4.4 for 1.4 feels weird to me. Maybe I'm biased 🤷♂️ |
|
@PrettyWood Makes sense, I'll change that. |
PrettyWood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You da man 👍
|
Nice work! Re, the versions: https://python-poetry.org/docs/dependency-specification/#caret-requirements |
Uh oh!
There was an error while loading. Please reload this page.