Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

@aminalaee
Copy link
Contributor

@aminalaee aminalaee commented Aug 17, 2021

  • Update Changelog
  • Bump version
  • ...

@aminalaee aminalaee requested a review from PrettyWood August 17, 2021 16:12
@aminalaee aminalaee requested a review from a team August 26, 2021 16:30
Copy link
Contributor

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this ☺️
2 remarks:

  • I'm not sure it is fix anymore since sqlachemy was already pinned. IMO it's more a feature "support sqlachemy 1.4". WDYT?
  • with this in mind should it be a 0.5.0 instead of a patched version since there is a breaking change?

Edit: sorry I'm on my phone travelling. Hard to type with those fat fingers

@aminalaee
Copy link
Contributor Author

Thanks for taking care of this
2 remarks:

  • I'm not sure it is fix anymore now that sqlachemy was pinned. IMO it's a more a feature "support sqlachemy 1.4"
  • with this in mind should it be a 0.5 instead of a patched version

@PrettyWood I agree about the first point.
About the second one, I actually thought the same thing, but since we've kept our API backwards compatible, shouldn't it be a patch only?

@PrettyWood
Copy link
Contributor

I reckon it's easier to have 0.4 only for sqlachemy<=1.3
0.5 for 1.4+
Maybe 0.6 for 1.5 if they add new breaking changes.

Having 0.4.3 for 1.3 and 0.4.4 for 1.4 feels weird to me. Maybe I'm biased 🤷‍♂️

@aminalaee
Copy link
Contributor Author

@PrettyWood Makes sense, I'll change that.

@aminalaee aminalaee changed the title prepare release v0.4.4 prepare release v0.5.0 Aug 26, 2021
@aminalaee aminalaee requested a review from PrettyWood August 26, 2021 16:47
Copy link
Contributor

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You da man 👍

@aminalaee aminalaee merged commit 0a06a5f into master Aug 26, 2021
@aminalaee aminalaee deleted the prepare-release-v0.4.4 branch August 26, 2021 16:50
@ghost
Copy link

ghost commented Aug 26, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants