Fix API documentation templates do not check for user authentication #5162 #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| valid_inputs = { | ||
| '2001-01-01 13:00': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc), | ||
| '2001-01-01T13:00': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc), | ||
| '2001-01-01T13:00Z': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc), |
Contributor
There was a problem hiding this comment.
This seems to be an erronous deletion.
Contributor
Author
There was a problem hiding this comment.
If i'm not misstict this is duplicated key
valid_inputs = {
'2001-01-01 13:00': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc),
'2001-01-01T13:00': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc),
- '2001-01-01T13:00Z': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc),
# Django 1.4 does not support timezone string parsing.
'2001-01-01T13:00Z': datetime.datetime(2001, 1, 1, 13, 00, tzinfo=utc)
}
In last attribute same key and value. I'm not sure about old version interpreter but new version interpreter remove first duplicated attributes
tests/test_request.py
Outdated
|
|
||
| return Response(status=status.HTTP_500_INTERNAL_SERVER_ERROR) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Let's drop these from the pull request.
If they're absolutely required because there's a newer version of the linter, then let's tackle them in a seperate pull request.
|
References #5162 |
Contributor
|
Thanks @myrubapa, @audiolion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5162.
Add case for check user auth
Lint fix