Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 21, 2017

No description provided.

@carltongibson
Copy link
Collaborator

@blueyed OK, happy to see this — is it really undefined?

@blueyed
Copy link
Contributor Author

blueyed commented Aug 21, 2017

Yes.
I've noticed it with pytest-django's --fail-on-template-vars.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py.test won't be wrong here and the only place the schema argument appears in a context is in the SchemaJSRenderer So OK.

@carltongibson carltongibson added this to the 3.6.4 Release milestone Aug 21, 2017
@carltongibson carltongibson merged commit 0a8fa52 into encode:master Aug 21, 2017
carltongibson added a commit to carltongibson/django-rest-framework that referenced this pull request Aug 21, 2017
For the last minute encode#5346
@blueyed blueyed deleted the docs-link-fix-undefined-schema branch August 21, 2017 18:37
@blueyed
Copy link
Contributor Author

blueyed commented Aug 23, 2017

Thanks for including it in the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants