-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Allow hashing of ErrorDetail #5932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmmm. I can see multiple errors occurring in the same place. Are they the same error? Probably not. How sophisticated to we need to be here? I might be inclined just to use the |
|
I've assumed that a hash should behave in the same way that TBH, my client's code which led me to this ticket is breaking my brain. They appear to somehow be getting a field name as an ErrorDetail, which breaks when they effectively do this: Is this something which should happen? If so, |
|
@carltongibson Please let me know if there's anything else I can do to have this PR included in the next release. |
|
@craiga Will do. I'm just having a little think about it. 👍 |
carltongibson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. This looks fine to me. We can address anything more complex as and when there's a demonstrated need for it. (i.e. a test case 🙂)
Thanks for the input @craiga!
|
Sorry to bother, when can I see this in a new release? It's been a while... |
|
Hi @nitrag. It looks like we’re targeting the end of this month for 3.9. Pip has first class VCS support if you need it urgently. |
Description
Allow hashing of ErrorDetail objects to address #5919.
I'm not entirely sure if
hash(ErrorDetail('msg')) == hash('msg')should be true. I'd love some feedback on this.