Skip to content

Conversation

@jackpope
Copy link
Contributor

The DOM fixture hasn't worked on local builds since the UMD support was removed in #28735

Here we update the fixture to set the local experimental builds to window. Some of the pages are still broken, such as hydration. But these bugs exist on other versions as well and can be cleaned up separately.

@react-sizebot
Copy link

react-sizebot commented Jan 15, 2025

Comparing: 87276ef1efb340467563c107f24248653d7f7f00...6dc099ea34635610dc5b207d538968ad5867cf57

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.73 kB 91.74 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 556.18 kB = 98.72 kB 98.72 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js = 17.57 kB 17.15 kB = 3.90 kB 3.78 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js = 1.80 kB 1.39 kB = 0.84 kB 0.71 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactReconcilerConstants-dev.classic.js +1.10% 0.63 kB 0.64 kB +1.45% 0.35 kB 0.35 kB
facebook-www/ReactReconcilerConstants-dev.modern.js +1.10% 0.63 kB 0.64 kB +1.45% 0.35 kB 0.35 kB
facebook-react-native/react/cjs/React-dev.js = 66.67 kB 66.17 kB = 14.68 kB 14.56 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 26.77 kB 26.39 kB = 6.31 kB 6.22 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 26.51 kB 26.13 kB = 6.29 kB 6.20 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js = 17.57 kB 17.15 kB = 3.90 kB 3.78 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js = 1.80 kB 1.39 kB = 0.84 kB 0.71 kB

Generated by 🚫 dangerJS against a16d6f1

@jackpope jackpope merged commit 6093f18 into facebook:main Jan 16, 2025
189 checks passed
@jackpope jackpope deleted the dom-fixture-local-react branch January 16, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants