Skip to content

Conversation

@frodi-karlsson
Copy link
Contributor

@frodi-karlsson frodi-karlsson commented Mar 8, 2025

Closes #212

Hello, tiniest little pr coming in hot 👋 This is the recommended approach from the deprecation description here

Looking at closed PRs I saw that there are cases of not including a CHANGES.md entry for small changes, and I thought this might qualify

@codecov
Copy link

codecov bot commented Mar 8, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@frodi-karlsson
Copy link
Contributor Author

frodi-karlsson commented Mar 8, 2025

Hm, the error in the release-test job seems to come from bodyUsed being truthy (line in check) in this test (handler.test.ts:L1174). I can't reproduce it locally, using the same node and deno version as the actions runner, so I'm at a bit of a loss

Edit:
I suspect it has to do with a call to verifyRequest in one of the previous handleInbox calls with unsignedRequest which then calls request.arrayBuffer without a clone(), but I'm unsure what this PR changes there and have a hard time verifying anything without reproducability 🤔

@dahlia
Copy link
Member

dahlia commented Mar 8, 2025

Oh, that's a flaky test. Never mind!

@dahlia dahlia merged commit 94cbc27 into fedify-dev:1.0-maintenance Mar 9, 2025
21 of 23 checks passed
@dahlia
Copy link
Member

dahlia commented Mar 9, 2025

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants