Context.federation property
#235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new Context.federation property to allow access to the Federation object within test contexts and dispatcher callbacks. Key changes include:
- Adding a federation parameter in createContext, createRequestContext, and related functions.
- Updating test files to instantiate and pass the federation object.
- Enhancing documentation and release notes to describe the new property.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fedify/webfinger/handler.test.ts | Updated tests to include a federation instance |
| fedify/testing/context.ts | Modified context creation to accept and expose federation |
| fedify/nodeinfo/handler.test.ts | Updated tests to pass federation to createRequestContext |
| fedify/federation/middleware.test.ts | Added assertions to ensure context.federation is set |
| fedify/federation/handler.test.ts | Updated multiple tests to provide federation in context |
| fedify/federation/context.ts | Added federation property to the Context interface |
| docs/manual/federation.md | Updated documentation to cover Context.federation usage |
| CHANGES.md | Documented release notes regarding Context.federation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.