-
-
Notifications
You must be signed in to change notification settings - Fork 88
Create fedify webfinger command for isolated WebFinger lookups
#278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new command-line utility, fedify webfinger, designed to simplify and isolate WebFinger lookups. This enhancement provides users with a direct way to query WebFinger resources for a given handle, improving debugging and information retrieval capabilities within the fedify ecosystem.
Highlights
- New CLI Command: I've implemented a new
fedify webfingercommand to perform isolated WebFinger lookups directly from the command line. - Handle Input and JSON Output: This command accepts a handle in the
@user@domainformat as input and outputs the WebFinger JRD (JSON Resource Descriptor) results in a clear JSON format. - Robust Error Handling: The command includes graceful error handling for cases such as invalid handle formats and failures during the WebFinger lookup process, providing informative messages to the user.
- CLI Integration and Usability: The new
webfingercommand has been fully integrated into the mainfedifyCLI, complete with appropriate help text and usage examples for ease of use.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a fedify webfinger command for isolated WebFinger lookups. The implementation has areas for improvement in argument handling, error handling, regex validation, and URI construction.
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution, and welcome!
Overall, you've implemented the discussion from issue #260 well, and it looks good. However, I've left some review comments.
Also, all changes must be documented in the CHANGES.md file, right? You can add the changes roughly like this:
- Added `fedify webfinger` command.Additionally, you'll need to document the new command in the docs/cli.md file. You can refer to existing documentation and follow a similar format for this part.
|
The docs for this pull request have been published: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a section about the new CLI command fedify webfinger in the docs/cli.md file? If you're having trouble with documentation, I can help through pair programming or other methods.
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general! I left few review comments, but all of them are all trivial.
2chanhaeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last one!
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and patience! Everything looks good now. I'm merging this soon.
Implement a new
fedify webfinger <handle>command to perform isolated WebFinger lookups. This command accepts a@user@domainformat handle and outputs the WebFinger result in JSON format. It utilizes the existinglookupWebFinger()function and handles errors related to invalid handles and lookup failures gracefully. The command is registered in the CLI module system with appropriate help text and usage examples.fedify webfinger <handle>command@user@domainformat handles as input