fix(webfinger): Add configurable maxRedirection option to lookupWebFinger

[notJoon]

Description

fixes #248

Changes

• Added maxRedirection field to LookupWebFingerOptions interface
• Updated lookupWebFingerInternal to use the configurable value with a default of 5
• Renamed MAX_REDIRECTION constant to DEFAULT_MAX_REDIRECTION

[gemini-code-assist]

Summary of Changes

Hello @notJoon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option for the lookupWebFinger function, allowing users to specify the maximum number of HTTP redirections to follow. This enhances flexibility for WebFinger lookups, which previously had a hardcoded redirection limit, while maintaining a sensible default.

Highlights

• Configurable Redirection Limit: The lookupWebFinger function now accepts a maxRedirection option within its LookupWebFingerOptions, enabling callers to define the maximum number of HTTP redirects to follow during a WebFinger lookup.
• Default Redirection Behavior: The default maximum redirection limit for WebFinger lookups remains 5. This ensures existing behavior is preserved when the maxRedirection option is not explicitly provided, while allowing for custom overrides.
• Comprehensive Testing: New test cases have been added to lookup.test.ts to thoroughly validate the functionality of the maxRedirection option. These tests cover scenarios where the redirection limit is reached, exceeded, and when the default behavior is expected.
• Build Configuration Update: The .gitignore file has been updated to include package-lock.json, preventing this file from being tracked by Git.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a configurable maxRedirection option for WebFinger lookups. The implementation is straightforward and includes corresponding tests to verify the new functionality.

[dahlia]

Thanks for your first contribution! Could you add a changelog entry to CHANGES.md? E.g.:

 -  Added `LookupWebFingerOptions.maxRedireaction` option.
    [[#248], [#281] by Lee ByeongJun]

[#248]: https://github.com/fedify-dev/fedify/issues/248
[#281]: https://github.com/fedify-dev/fedify/pull/281

[dahlia]

For your information, you have to use pnpm instead npm when you work on Fedify.

[notJoon]

removed eb9a205 👍

[dahlia]

Everything looks good! Thanks again!