Skip to content

Conversation

@dodok8
Copy link
Contributor

@dodok8 dodok8 commented Jul 31, 2025

Summary

Make Fedify integration plugin for Elysia.

Related Issue

Changes

  • elysia directory
  • Bun monorepo setting
  • Build scripts for bun
  • Move example to example directory(Current it is located in elysia folder)

Benefits

It helps Elysia users using Fedify

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

Additional Notes

Include any other information, context, or considerations.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a new integration plugin for the Elysia web framework, enabling developers to easily build federated applications using Fedify within the Elysia ecosystem. It provides the core middleware to connect Fedify's federation capabilities with Elysia's request handling, along with a comprehensive example to guide implementation.

Highlights

  • New Elysia Integration Plugin: I've introduced a new @fedify/elysia package within a dedicated elysia/ directory. This package provides a plugin to seamlessly integrate Fedify with the Elysia web framework, allowing Elysia applications to easily handle ActivityPub federation.
  • Core Integration Logic: The src/index.ts file contains the main fedify plugin for Elysia. It decorates the Elysia app with the Fedify Federation instance and implements an onRequest hook that uses federation.fetch to process incoming requests. It also includes logic to gracefully handle cases where Fedify does not process a request (e.g., onNotFound, onNotAcceptable), allowing Elysia's routing to take over.
  • Comprehensive Example: A detailed example.ts is provided, demonstrating how to set up a basic Fedify application using the new Elysia plugin. This example includes configuration for NodeInfo, actor dispatching, key pair generation, and handling of ActivityPub Follow and Undo activities, showcasing a functional federated server.
  • Bun-centric Setup: The new integration is configured with Bun, including a bun.lock file and package.json scripts tailored for Bun, indicating a focus on performance and modern JavaScript runtime capabilities for this integration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added component/integration Web framework integration priority/medium Medium priority issues runtime/bun Bun runtime related type/feature Requests for new features labels Jul 31, 2025
@dodok8
Copy link
Contributor Author

dodok8 commented Jul 31, 2025

Currently, I'm working on bun run elysia/example.ts. fedify node works on here, but I can't find a user using another ActivityPub Client.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new integration for using Fedify with the Elysia web framework. The changes include the core plugin logic, a comprehensive example, and necessary configuration files. My review has identified a few critical and high-severity issues that should be addressed. These include a configuration error in package.json, incorrect response handling in the main plugin file that misuses the Elysia API, and a potential server crash in the example code due to unhandled errors. Additionally, there are opportunities to improve the example code's clarity. Overall, this is a great initiative, and with these fixes, it will be a robust and valuable package for the community.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025

The docs for this pull request have been published:

https://6fc3643c.fedify.pages.dev

@dahlia
Copy link
Member

dahlia commented Jul 31, 2025

You should run deno fmt inside the elysia/ directory.

@dodok8 dodok8 force-pushed the dodok8-fix-issue-286 branch from ac42acb to ff5fb9e Compare August 4, 2025 04:14
@dodok8 dodok8 marked this pull request as ready for review August 4, 2025 05:04
@dodok8 dodok8 force-pushed the dodok8-fix-issue-286 branch from 1bee31e to d6dc102 Compare August 4, 2025 05:13
@dodok8
Copy link
Contributor Author

dodok8 commented Aug 4, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Fedify integration for the ElysiaJS framework, which is a great addition for developers using the Bun runtime. The changes are well-structured, including a new package, an example application, and documentation updates.

I've found a few issues that need attention. The most important is a bug in the Elysia plugin that incorrectly handles HTTP headers with multiple values, which could lead to problems with features like setting multiple cookies. Additionally, there are several copy-paste errors in the documentation and a typo in the root package.json that should be corrected for clarity and to prevent potential workspace issues.

Overall, this is a valuable contribution, and with these fixes, it will be ready for merging.

@dodok8 dodok8 force-pushed the dodok8-fix-issue-286 branch from 937f9dc to 9082480 Compare August 4, 2025 12:43
@dodok8
Copy link
Contributor Author

dodok8 commented Aug 4, 2025

Currently, deno task build failed on local, pnpm run build succeeded.

@dodok8 dodok8 force-pushed the dodok8-fix-issue-286 branch from 28c0023 to 51e62bc Compare August 5, 2025 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package Version JSR npm
@fedify/fedify 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/cli 1.8.1-pr.339.1323+51e62bcd JSR
@fedify/amqp 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/express 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/h3 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/nestjs 1.8.1-pr.339.1323+51e62bcd npm
@fedify/postgres 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/redis 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/sqlite 1.8.1-pr.339.1323+51e62bcd JSR npm
@fedify/testing 1.8.1-pr.339.1323+51e62bcd JSR npm

@dahlia dahlia merged commit 58d26de into fedify-dev:main Aug 5, 2025
10 checks passed
@dodok8 dodok8 deleted the dodok8-fix-issue-286 branch August 23, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/integration Web framework integration priority/medium Medium priority issues runtime/bun Bun runtime related type/feature Requests for new features

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Elysia integration

2 participants