-
-
Notifications
You must be signed in to change notification settings - Fork 88
Elysia integration #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elysia integration #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers a new integration plugin for the Elysia web framework, enabling developers to easily build federated applications using Fedify within the Elysia ecosystem. It provides the core middleware to connect Fedify's federation capabilities with Elysia's request handling, along with a comprehensive example to guide implementation.
Highlights
- New Elysia Integration Plugin: I've introduced a new
@fedify/elysiapackage within a dedicatedelysia/directory. This package provides a plugin to seamlessly integrate Fedify with the Elysia web framework, allowing Elysia applications to easily handle ActivityPub federation. - Core Integration Logic: The
src/index.tsfile contains the mainfedifyplugin for Elysia. It decorates the Elysia app with the FedifyFederationinstance and implements anonRequesthook that usesfederation.fetchto process incoming requests. It also includes logic to gracefully handle cases where Fedify does not process a request (e.g.,onNotFound,onNotAcceptable), allowing Elysia's routing to take over. - Comprehensive Example: A detailed
example.tsis provided, demonstrating how to set up a basic Fedify application using the new Elysia plugin. This example includes configuration for NodeInfo, actor dispatching, key pair generation, and handling of ActivityPubFollowandUndoactivities, showcasing a functional federated server. - Bun-centric Setup: The new integration is configured with Bun, including a
bun.lockfile andpackage.jsonscripts tailored for Bun, indicating a focus on performance and modern JavaScript runtime capabilities for this integration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Currently, I'm working on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new integration for using Fedify with the Elysia web framework. The changes include the core plugin logic, a comprehensive example, and necessary configuration files. My review has identified a few critical and high-severity issues that should be addressed. These include a configuration error in package.json, incorrect response handling in the main plugin file that misuses the Elysia API, and a potential server crash in the example code due to unhandled errors. Additionally, there are opportunities to improve the example code's clarity. Overall, this is a great initiative, and with these fixes, it will be a robust and valuable package for the community.
|
The docs for this pull request have been published: |
|
You should run |
330460c to
c179ce6
Compare
ac42acb to
ff5fb9e
Compare
1bee31e to
d6dc102
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Fedify integration for the ElysiaJS framework, which is a great addition for developers using the Bun runtime. The changes are well-structured, including a new package, an example application, and documentation updates.
I've found a few issues that need attention. The most important is a bug in the Elysia plugin that incorrectly handles HTTP headers with multiple values, which could lead to problems with features like setting multiple cookies. Additionally, there are several copy-paste errors in the documentation and a typo in the root package.json that should be corrected for clarity and to prevent potential workspace issues.
Overall, this is a valuable contribution, and with these fixes, it will be ready for merging.
937f9dc to
9082480
Compare
|
Currently, |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
28c0023 to
51e62bc
Compare
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
Summary
Make Fedify integration plugin for Elysia.
Related Issue
Changes
elysiadirectoryBenefits
It helps Elysia users using Fedify
Checklist
deno task test-allon your machine?Additional Notes
Include any other information, context, or considerations.