Fixed SvelteKit integration hook types

[2chanhaeng]

Summary

Fixed SvelteKit integration hook types.

Related Issue

• fixes SvelteKit integration hook has the wrong type #271

Changes

• packages/sveltekit

Benefits

Now users who use SvelteKit integration can get proper hook types.

Checklist

• Did you add a changelog entry to the CHANGES.md?
• [ ] Did you write some relevant docs about this change (if it's a new feature)?
• Did you write a regression test to reproduce the bug (if it's a bug fix)?
• [ ] Did you write some tests for this change (if it's a new feature)?
• Did you run deno task test-all on your machine?

Additional Notes

[gemini-code-assist]

Summary of Changes

Hello @2chanhaeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the SvelteKit integration by resolving type inference issues within its hooks. By adopting SvelteKit's native type definitions, the changes ensure that users receive accurate request and response types, making the integration more robust and easier to work with, ultimately improving the overall developer experience for SvelteKit users.

Highlights

• SvelteKit Type Inference Fix: The pull request addresses an issue where SvelteKit integration hooks did not correctly infer request and response types, leading to improved type safety and developer experience.
• Dependency Update: The @sveltejs/kit package has been explicitly added as a dependency in packages/sveltekit/deno.json to support the type improvements.
• Refactored Hook Definitions: Custom RequestEvent and HookParams types within packages/sveltekit/src/mod.ts have been replaced with direct imports of Handle and RequestEvent from @sveltejs/kit, aligning the integration more closely with SvelteKit's native types.
• Simplified fedifyHook Signature: The fedifyHook function now leverages the Handle type from SvelteKit and provides a default createContextData function, simplifying its usage.
• Updated Test Suite: The test file packages/sveltekit/src/mod.test.ts has been updated to reflect the new type definitions and ensure compatibility with the SvelteKit-native types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[dahlia]

Shouldn't we change the package.json either?

[gemini-code-assist]

Code Review

This pull request fixes the SvelteKit integration hook types by using the official types from @sveltejs/kit and making the createContextData parameter optional. The changes are in the right direction, but I've found a type safety issue in the implementation of the optional parameter which could lead to runtime errors. I've suggested using function overloads to fix this. I also noticed a minor omission in the CHANGES.md file.