Make GET_VERSION_TIMEOUT settable via env vars #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
Jul 15, 2023
src/findpython/python.py
Outdated
| _DEFAULT_GET_VERSION_TIMEOUT = 5 | ||
|
|
||
|
|
||
| def get_version_timeout() -> float: |
Owner
There was a problem hiding this comment.
Why get the value on-the-fly instead of freezing it when start up? Is there any practical cases?
Contributor
Author
There was a problem hiding this comment.
That’s what I generally do with these sorts of environment, variables to avoid issues with sequencing of setting and reading. But happy to make it a global if you’d prefer.
Owner
There was a problem hiding this comment.
Yes please do, lack of practical case and inefficient function call
frostming
approved these changes
Jul 15, 2023
Contributor
Author
|
Thanks for merging this so quickly! Mind cutting a release? |
Adirelle
pushed a commit
to Adirelle/findpython
that referenced
this pull request
Jul 17, 2023
* Make GET_VERSION_TIMEOUT settable by env vars * Make GET_VERSION_TIMEOUT a global * remove ,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that some interpreters, in particular, PyPy, can be so slow to start up under resource-constrained environments (in particular GitHub Actions runners) that 5s is not enough.
Instead of just making it 30s we can make it settable by env vars so that most users can fail fast but we can set it higher in CI.