Skip to content

Conversation

@dungpa
Copy link
Contributor

@dungpa dungpa commented Jan 20, 2014

FSharp.Formatting 2.3.4-beta finally is able to generate API docs for FSharp.Compiler.Service.

I adjusted the build script to generate API docs for public members and automatically create GitHub links to all functions and members.
It takes 200 seconds in my machine (not bad).

Documentation needs some love, but once the first version goes live; it is much easier to improve.

@7sharp9
Copy link
Member

7sharp9 commented Jan 20, 2014

200 seconds? That seems like a long time...

@dungpa
Copy link
Contributor Author

dungpa commented Jan 20, 2014

It's interplay of Razor, templating and a huge API space of FSharp.Compiler.Service. There's certainly a lot of rooms for improvements.

@7sharp9
Copy link
Member

7sharp9 commented Jan 20, 2014

Yeah I would love an alternative to razor, the C# compilation seems to take an age.

ghost pushed a commit that referenced this pull request Jan 20, 2014
@ghost ghost merged commit bfceed5 into fsharp:master Jan 20, 2014
@tpetricek
Copy link
Member

Nice! Razor is not perfect and having an alternative would be nice (@7sharp9 feel free to submit a pull request!) That said, you only need to build the documentation when releasing a new version, so I think 200seconds is fine. Also, this actually utilizes multi-core CPU, so it might be faster if you have more CPUs!

@7sharp9
Copy link
Member

7sharp9 commented Jan 20, 2014

Ive been using it for generating blog posts in ‘real-time’ unfortunately.

On 20 Jan 2014, at 18:26, Tomas Petricek [email protected] wrote:

Nice! Razor is not perfect and having an alternative would be nice (@7sharp9 feel free to submit a pull request!) That said, you only need to build the documentation when releasing a new version, so I think 200seconds is fine. Also, this actually utilizes multi-core CPU, so it might be faster if you have more CPUs!


Reply to this email directly or view it on GitHub.

@tpetricek
Copy link
Member

I generated & published the documentation. Looks quite nice - for example, see the InteractiveChecker type: http://fsharp.github.io/FSharp.Compiler.Service/reference/microsoft-fsharp-compiler-sourcecodeservices-interactivechecker.html

It took about 10 minutes on my poor laptop, which is a bit long. The main problem is that RazorEngine re-compiles the templates every time it is run (I think), so this should be fixable just by pre-compiling the templates and calling them repeatedly with different Model objects.

@7sharp9
Copy link
Member

7sharp9 commented Jan 20, 2014

I found that the Razor.Core in literate doesn't work for me, I get a missing method exception.

I had to use a newer verson of Razor.Core with a patch:
https://github.com/7sharp9/RazorEngine/commit/2098fb0264839b09601f5b2bf335eafa567d352e

ghost pushed a commit that referenced this pull request Mar 31, 2014
@dungpa dungpa deleted the documentation branch May 11, 2014 11:17
dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Mar 23, 2015
fixes fsharp#30
closes fsharp#167

commit ef01ef3962261a4f091c1d8f7c74423274bade28
Author: andrewjkennedy <[email protected]>
Date:   Thu Jan 29 15:21:05 2015 +0000

    Whitespace change to kick AppVeyor

commit 6cc2e7734f867fe976cd63bc33d7cfe35161710b
Author: andrewjkennedy <[email protected]>
Date:   Thu Jan 29 10:02:20 2015 +0000

    Regression test for issue fsharp#30

commit 72635a9929fb09dd58b9b3e071247a22458d78b8
Author: andrewjkennedy <[email protected]>
Date:   Wed Jan 28 12:42:32 2015 +0000

    Fix for dotnet/fsharp#30
    Code was comparing a pre-erasure list of arguments with a post-erasure list
dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Aug 24, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants