fix: Test transport rate limits parsing and enforcement #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug where missing categories ("123::project") would not
enforce a rate limit for all categories, as they were parsed as category
"" instead of category None.
jan-auer
approved these changes
Mar 20, 2020
Member
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
Looks good. Would you mind to also add a test for rate limits without categories (e.g. 4711::organization)?
Member
Author
|
That should be this one (from the rust impl): https://github.com/getsentry/sentry-python/pull/652/files#diff-50acfff8adfa27fc0ebafc7c5a4b5754R71 |
Member
|
@untitaker Sorry for the ambiguity. I meant enforcement, not parsing. |
jan-auer
approved these changes
Mar 23, 2020
Member
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
LGTM but doesn't LGT the linter :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a bug where missing categories ("123::project") would not
enforce a rate limit for all categories, as they were parsed as category
"" instead of category None.