Skip to content

Fix bug in _update_scope() #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
untitaker merged 2 commits into from
Mar 31, 2020
Merged

Fix bug in _update_scope() #662

untitaker merged 2 commits into from
Mar 31, 2020

Conversation

@vasilty
Copy link
Contributor

@vasilty vasilty commented Mar 31, 2020

Introduced in e680a75

@untitaker
Copy link
Member

untitaker commented Mar 31, 2020

Thanks, can you add a small test for this in test_basic?

@vasilty vasilty force-pushed the feature/fix_update_scope branch from 1577f3a to 961f710 Compare March 31, 2020 11:48
@vasilty
Copy link
Contributor Author

vasilty commented Mar 31, 2020

@untitaker Sure, I added the test.

@untitaker untitaker merged commit f49d620 into getsentry:master Mar 31, 2020
@untitaker
Copy link
Member

untitaker commented Mar 31, 2020

Thanks! Do you need a new release?

@vasilty
Copy link
Contributor Author

vasilty commented Mar 31, 2020

We are fine waiting till the next planned one comes out. Thank you for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vasilty @untitaker