ref: enable local_partial_types=True #89854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #89854 +/- ##
===========================================
+ Coverage 63.44% 87.70% +24.25%
===========================================
Files 10204 10206 +2
Lines 575452 575449 -3
Branches 22677 22677
===========================================
+ Hits 365106 504682 +139576
+ Misses 209910 70331 -139579
Partials 436 436 |
this setting is required by dmypy and needed to auto type things
asottile-sentry
force-pushed
the
asottile-partial-types
branch
from
ef0c1b9 to
3f102b9
Compare
wedamija
approved these changes
Apr 17, 2025
asottile-sentry
added
the
Trigger: Revert
Contributor
|
PR reverted: 5198907 |
getsentry-bot
added a commit
that referenced
this pull request
Apr 18, 2025
This reverts commit ed98fca. Co-authored-by: asottile-sentry <[email protected]>
Contributor
Author
|
looks like our production configuration is broken -- will try again after I fix that: |
asottile-sentry
added a commit
that referenced
this pull request
Apr 21, 2025
This reverts commit 5198907.
asottile-sentry
added a commit
that referenced
this pull request
Apr 22, 2025
first commit automated via https://github.com/getsentry/auto-type-annotate - I used these patches to mypy: - python/mypy#18948 - (the line mentioned in the issue commented out): python/mypy#18940 (comment) - and with this unreverted (coming soon!): #89854 <!-- Describe your PR here. -->
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
this setting is required by dmypy and needed to auto type things <!-- Describe your PR here. -->
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
This reverts commit ed98fca. Co-authored-by: asottile-sentry <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
first commit automated via https://github.com/getsentry/auto-type-annotate - I used these patches to mypy: - python/mypy#18948 - (the line mentioned in the issue commented out): python/mypy#18940 (comment) - and with this unreverted (coming soon!): #89854 <!-- Describe your PR here. -->
asottile-sentry
added a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit 5198907. clean reapply -- I've fixed the filestore options in production via https://github.com/getsentry/getsentry/pull/17256 and https://github.com/getsentry/getsentry/pull/17262 <!-- Describe your PR here. -->
getsentry-bot
added a commit
that referenced
this pull request
Apr 24, 2025
…)" This reverts commit c757c35. Co-authored-by: GabeVillalobos <[email protected]>
markstory
added a commit
that referenced
this pull request
Apr 24, 2025
markstory
added a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this setting is required by dmypy and needed to auto type things