Misc. bug: WebUI can't change any setting to value 0

[smirkun]

Name and Version

version: 205 (a86a580)
built with cc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 for x86_64-linux-gnu

Operating systems

Linux

Which llama.cpp modules do you know to be affected?

llama-server

Command line

llama-server -m model.gguf

Problem description & steps to reproduce

You can't change a setting to 0 in the settings menu. The UI seems to indicate that the setting is reverted to the default after you click Save.

1. Open llama-server web UI.
2. Click settings cog button to open the settings menu
3. In Penalties set Repeat penalty to 0.
4. Click 'save settings'
5. Click settings cog button again to open the settings menu
6. Click Penalties. the Repeat penalty says it is set to the default of 1!

First Bad Commit

Svelte web UI from @allozaur

Relevant log output

[ggerganov]

Similar problem with Top-K.

The value of 0 is accepted and applied, but the UI makes it seem like the default value is used instead.

@smirkun Not directly related to this bug, but using repetition penalty of 0 is not recommended. If you want to disable the repetition penalty (which is disabled by default), use a value of 1.

[notgood]

In general, re-examining the logic behind the settings in webui might be benificial.

The whole "server defaults" vs "web defaults" vs "server command line settings" vs "webui settings" relation could be streamlined and simplified.

Related #16201

[engrtipusultan]

--props enable changing global properties via POST /props (default: disabled)
(env: LLAMA_ARG_ENDPOINT_PROPS)

If sampling properties are always overridden by client call then which properties are referred above in llama-server documentation.

[allozaur]

Hey, thanks for reporting the bug! As it goes for the /props-enpoint-based settings we are planning to implement setting this via UI¹, but I'd prefer doing this with a separate PR. For this issue i will fix the WebUI showing wrong UI feedback when setting 0 value.

Footnotes

1. https://github.com/ggml-org/llama.cpp/pull/14839#issuecomment-3302414096 ↩

[engrtipusultan]

Hey, thanks for reporting the bug! As it goes for the /props-enpoint-based settings we are planning to implement setting this via UI1, but I'd prefer doing this with a separate PR. For this issue i will fix the WebUI showing wrong UI feedback when setting 0 value.

Footnotes

1. https://github.com/ggml-org/llama.cpp/pull/14839#issuecomment-3302414096 [↩](#user-content-fnref-1-44e415dbba6a246c4d5b8e4dc6b15a7c)

My question was more from understanding point of view that what "--props enable changing global properties via POST /props" is this for. I believe it is not standard OpenAI endpoint.
If it is used for changing global sampling settings that are set via cli at launch is it required when this functionality is there through /chat/completions

[ServeurpersoCom]

It's a nullish coalescing (??) instead of logical OR (||) I tested this with a temperature of 0 :
master...ServeurpersoCom:llama.cpp:zero-in-conf

[smirkun]

Yes good thing the code already handles the case where an empty string means use the default https://github.com/ggml-org/llama.cpp/blob/070939562444dc4ff99d10c5f93a63ba7767b094/tools/server/webui/src/lib/components/app/chat/ChatSettings/ChatSettingsDialog.svelte#L299

[allozaur]

It's a nullish coalescing (??) instead of logical OR (||) I tested this with a temperature of 0 :
master...ServeurpersoCom:llama.cpp:zero-in-conf

@ServeurpersoCom can you please prepare a PR with this change?