Test-based VRAM scratch size + context adjustment #2056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2019 the current fixed size of the VRAM scratch buffer at some point becomes an issue if the context is increased beyond 2048. This PR adjusts the VRAM scratch value based on test values; it seems that 1 MB of scratch size is needed per 512 extra context and per
n_head:Details
I did not test 3b, I'm using the 7b values instead. Testing for 33b was limited by VRAM. Similarly I was not able to test 65b at all so I'm using double the values of 33b to be conservative. The base size of the VRAM scratch buffers is chosen so that there is a +25% margin at 2048 context. This PR does not fix the issue with the RAM scratch buffers being considered too small at high context.