Fix unicode in grammars (fixes #2501) #2553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2501, the grammar implementation incorrectly assumes that tokens contain full UTF-8 sequences. In reality, a unicode character may span (the bytes of) several tokens. This patch fixes the issue with the suggestion from @ai-and-i to track partial UTF-8 sequences and match against the range of unicode code points it represents.
Changes
decode_utf8return partial and invalid UTF-8 sequences, and to resume from a partial UTF-8 sequenceTesting
Emojis (from #2501)
Student schema (Jsonformer)
CJK