Add Orion chat template #6066
Merged
Add Orion chat template #6066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@ngxson you assigned me something ? I have no value added at the moment on chat templates. But your contribution to support new ones taking into account our plain old c++ is very useful. |
Collaborator
Author
|
@phymbert sorry I misclicked and didn’t notice that. Don’t worry though. And to response to your deleted message: Et oui je parle français ;-) |
Collaborator
Author
|
Btw this template is so weird, they have EOS token everywhere. Looks like some researchers “just do it” and don’t care about optimizing |
ggerganov
approved these changes
Mar 15, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6009
Chat template is updated on wiki: https://github.com/ggerganov/llama.cpp/wiki/Templates-supported-by-llama_chat_apply_template