This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Make init more proactive in reporting errors
#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'GitHelper.CloneBareRepo()' fails, it returns an error. However, the 'init' command ignores this error and attempts to create a base bundle then fail. Update 'init' to instead exit with the error it receives from 'CloneBareRepo()'. Signed-off-by: Victoria Dye <[email protected]>
If 'ReadDirRecursive()' receives a non-existent root path, the initial 'os.ReadDir()' throws a ENOENT error. Handle this case more gracefully (i.e., without error) by returning an empty entry list with no error if the we should exit gracefully if the error from 'os.ReadDir()' is 'os.ErrNotExist' (corresponding to ENOENT). Signed-off-by: Victoria Dye <[email protected]>
If 'init' tries to initialize a new route, but that route already exists on disk (enabled or not), exit with an error. Without this explicit check, the initialization will fail anyway (specifically, the bare repo clone), but the call to 'RepositoryProvider.CreateRepository()' will enable the existing route even if it was disabled. To avoid that unintended behavior and provide clearer information to users, explicitly check for existing routes before 'CreateRepository()' and exit if the route already exists. Signed-off-by: Victoria Dye <[email protected]>
derrickstolee
approved these changes
May 18, 2023
Collaborator
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
These look like excellent, small fixes. Testing them properly would involve integration-level tests for the most part, but they are also so small we can move forward without them for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
This pull request fixes the remaining item in #35 (
git-bundle-server initbehaves incorrectly when the specified route already exists). The update to fix this revealed a different bug affecting usage ofReadRepositoryStorage()(repairand, as of this PR,init) when the bundle server directory structure hasn't been created yet.initto exit if it receives an error fromCloneBareRepo(), rather than trying to continue with creating a base bundle (as it does now).ReadRepositoryStorage()by ensuringReadDirRecursive()catches "missing entry" errors and returns an empty result rather than an error.CreateRepository(). If the route is found in the results ofReadRepositoryStorage(), exit with an error.