Fix delay when cmd tabbing into GitUp #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So `NSApplicationDidBecomeActiveNotification` isn't blocked so command-tabbing into GitUp isn't delayed because we're refreshing all the repositories synchronously. The work will still be done on the main thread, but it will now be less likely to be noticed (especially with Stage Manager activated, the reload will probably be done by the time the Stage Manager animation is done)
lapfelix
changed the title
_didBecomeActive into a main queue async dispatch
Contributor
|
Just wanted to say—that's a really clever fix! A pretty big difference in UX for very little code change :) |
Collaborator
|
Seems like a reasonable tradeoff. |
|
Thank you so much @lapfelix, this fixed the issue for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
NSApplicationDidBecomeActiveNotificationisn't blocked so command-tabbing into GitUp isn't delayed because we're refreshing all the repositories synchronously. The work will still be done on the main thread, but it will now be less likely to be noticed (especially with Stage Manager activated, the reload will probably be done by the time the Stage Manager animation is done)Steps to reproduce the problem before:
Before:
Takes 1-2 seconds before macOS actually switches to GitUp.
With the async dispatch:
macOS instantly switches to GitUp, but the app is unresponsive for 1-2 seconds.
I AGREE TO THE GITUP CONTRIBUTOR LICENSE AGREEMENT