Update CodeQL workflow #5086
Merged
Update CodeQL workflow #5086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcogario
reviewed
Feb 4, 2021
marcogario
previously approved these changes
Feb 4, 2021
Contributor
marcogario
left a comment
marcogario
left a comment
There was a problem hiding this comment.
We could further reduce this by changing the triggers to :
push: [main, v1]
pull_request: [main, v1]
tibbes
force-pushed
the
update-codeql-workflow
branch
from
e617954 to
63e2c23
Compare
Bring the CodeQL workflow up to date with the latest recommended configuration, which analyses the merge commit of pull requests (not the head of the PR branch).
Analysing all branches on both 'push' and 'pull request' events causes duplicate analysis. It is only necessary to analyse the _target_ branches of pull requests on push.
tibbes
force-pushed
the
update-codeql-workflow
branch
from
63e2c23 to
121ffbb
Compare
hvitved
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default workflow for CodeQL / code scanning has been updated to analyse the merge commit of pull requests rather than the head commit. This is now the preferred configuration.