Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Conversation

@rewinfrey
Copy link
Contributor

@rewinfrey rewinfrey commented Mar 2, 2020

This patch enables precise ASTs for CodeQL.

After the related tree-sitter-ql updated grammar is merged, I'll create a tree-sitter-ql package on hackage, and incorporate that into haskell-tree-sitter, which should remove all the temporarily vendored code in semantic to verify the PoC.

Rick Winfrey added 30 commits February 27, 2020 16:32
This reverts commit bf056d0, reversing
changes made to 147245d.
@rewinfrey rewinfrey requested a review from patrickt March 31, 2020 18:58
@rewinfrey
Copy link
Contributor Author

This adds ToTags support for modules, classes, predicates, and various call permutations in tree-sitter-ql's grammar.

These changes are subsumed by semantic-source version 0.1.0.0
@rewinfrey rewinfrey changed the title [WIP] Precise ql tagging Precise AST CodeQL tagging Mar 31, 2020
@rewinfrey rewinfrey requested review from a team and tclem and removed request for patrickt and tclem March 31, 2020 22:29
Copy link
Member

@tclem tclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look 👍

Noticed that it's still tree-sitter-ql - do we want to rename that as well? Easier to do now I would guess.

Copy link
Contributor

@patrickt patrickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haskell parts look great to me! Cheers, @rewinfrey!

@rewinfrey rewinfrey merged commit 2684890 into master Apr 1, 2020
@rewinfrey rewinfrey deleted the precise-ql-tagging branch April 1, 2020 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants