This repository was archived by the owner on Apr 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 459
Precise AST CodeQL tagging #507
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f code nav languages
Contributor
Author
|
This adds |
rewinfrey
commented
Mar 31, 2020
These changes are subsumed by semantic-source version 0.1.0.0
tclem
approved these changes
Apr 1, 2020
Member
tclem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look 👍
Noticed that it's still tree-sitter-ql - do we want to rename that as well? Easier to do now I would guess.
patrickt
approved these changes
Apr 1, 2020
Contributor
patrickt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haskell parts look great to me! Cheers, @rewinfrey!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables precise ASTs for
CodeQL.After the related
tree-sitter-qlupdated grammar is merged, I'll create atree-sitter-qlpackage on hackage, and incorporate that intohaskell-tree-sitter, which should remove all the temporarily vendored code insemanticto verify the PoC.