Support VSCodium in interactive rebase editor

[jingyu9575]

VSCodium is an open source build of vscode, and this extension works well on it. However, it uses the command codium instead of code and the interactive rebase editor is not launching.

Could you add a branch to the appName switch:

https://github.com/eamodio/vscode-gitlens/blob/2b8a300703103b12ab90b17e1ad0a2d6c9ece1e6/src/commands/git/rebase.ts#L81-L91

 	case 'VSCodium': 
 		editor = 'codium --wait --reuse-window'; 
 		break; 

Thank you!

[matronator]

Duplicate #1430

[jingyu9575]

@matronator I think this issue about the launch command is easier to implement than Github auth in #1430. It only needs a branch in the switch code.

[pmahend1]

I don't think this logic will work for authentication provision #1430 , it involves redirection code.

[earthnuker]

VSCodium is an open source build of vscode, and this extension works well on it. However, it uses the command codium instead of code and the interactive rebase editor is not launching.

Could you add a branch to the appName switch:

https://github.com/eamodio/vscode-gitlens/blob/2b8a300703103b12ab90b17e1ad0a2d6c9ece1e6/src/commands/git/rebase.ts#L81-L91

 	case 'VSCodium': 
 		editor = 'codium --wait --reuse-window'; 
 		break; 

Thank you!

I just tested the change suggested here and it works without issue, i don't see what authentication has to do with this since git rebase only modifies the local repository and does not talk to the remote

Best regards,

Earthnuker

[diggit]

I've also stumbled on this issue.
Hard coding executable names seems too fragile to me.
At least default should be empty so git configuration may work as fallback. User might have configured sequence.editor.
Or expose executable name through extension config.

[eamodio]

Fixed in 9994e13

[eamodio]

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.