Unable to find git note corresponding to the commit errors in log

[pboguslawski]

Description

Noticed errors like

2022/05/27 15:55:56 ...git/notes_nogogit.go:50:GetNote() [E] Unable to find git note corresponding to the commit "***". Error: object does not exist [id: , rel_path: 58]

in gitea 1.16.3 (built from sources) log.

Fix from similar issue #18616 is already applied in 1.16.3.

Gitea Version

1.16.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Build from sources.

Database

MySQL

[lunny]

So you mean #18616 has been fixed?

[pboguslawski]

Yes, it can see fix

https://github.com/go-gitea/gitea/pull/18635/files

is already present in 1.16.3

https://github.com/go-gitea/gitea/blame/v1.16.3/modules/git/notes_nogogit.go#L24

and this error was thrown by 1.16.3 so looks like one more bug.

[zeripath]

This is just a spurious logging line and can be safely ignored. #19884 will finally stop it.