Error 500 on tag

[hrubymar10]

• Gitea version (or commit ref): 8fffb06 built with go1.12 : bindata, sqlite, sqlite_unlock_notify
• Git version: 2.20.1
• Operating system: golang:1.12-alpine3.9 (Docker container)
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log:

2019/03/09 19:19:53 [...les/context/panic.go:36 1()] [E] PANIC:: runtime error: slice bounds out of range
/usr/local/go/src/runtime/panic.go:54 (0x433c3a)
/go/src/code.gitea.io/gitea/vendor/code.gitea.io/git/repo_commit.go:97 (0x912697)
/go/src/code.gitea.io/gitea/vendor/code.gitea.io/git/repo_commit.go:126 (0x912be5)
/go/src/code.gitea.io/gitea/vendor/code.gitea.io/git/repo_commit.go:162 (0x91324a)
/go/src/code.gitea.io/gitea/vendor/code.gitea.io/git/repo_commit.go:180 (0x913857)
/go/src/code.gitea.io/gitea/modules/context/repo.go:608 (0x115c07b)
/usr/local/go/src/reflect/value.go:447 (0x4ca770)
/usr/local/go/src/reflect/value.go:308 (0x4ca1f3)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x99c356)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x99bc4b)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9ca9f9)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x1158278)
/go/src/code.gitea.io/gitea/modules/context/panic.go:40 (0x115826b)
/usr/local/go/src/reflect/value.go:447 (0x4ca770)
/usr/local/go/src/reflect/value.go:308 (0x4ca1f3)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x99c356)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x99bc4b)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9ca9f9)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9ea896)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/session/session.go:192 (0x9ea881)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:79 (0x9ca8a0)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x99c010)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x99bd3a)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9ca9f9)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9dc3ff)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/recovery.go:161 (0x9dc3ed)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/logger.go:40 (0x9ce683)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x99c010)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x99bd3a)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9ca9f9)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9db720)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/logger.go:52 (0x9db70b)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/logger.go:40 (0x9ce683)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x99c010)
/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x99bd3a)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9ca9f9)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/router.go:187 (0x9dd646)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/router.go:303 (0x9d70e5)
/go/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/macaron.go:220 (0x9cfa5b)
/go/src/code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0xcd8ada)
/usr/local/go/src/net/http/server.go:1995 (0x6f32c3)
/usr/local/go/src/net/http/server.go:2774 (0x6f657a)
/usr/local/go/src/net/http/server.go:1878 (0x6f228b)
/usr/local/go/src/runtime/asm_amd64.s:1337 (0x4644f0)

Description

I can reproduce this problem for long time so it is not caused by latest changes. I am using gitea in docker and every time I try access the tag I get error 500. Example URL is: https://my.repo.com/ORG/REPO/src/tag/v0.1.1

[zeripath]

Hi! Could you check again on master? I think this should now be fixed.

[hrubymar10]

Cannot reproduce with b2e9894988a8cb486f8838f4bf532401124802c4.

Thank you for quick fix 👍

Closing