Add server config option for always rendering html code

[pgaskin]

• Gitea version (or commit ref): 1.0.1
• Git version: 2.9.3
• Operating system: Alpine Linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

I have a few repos of HTML code, in a repository on a server which only me and people I trust access. I would like there to be a server configuration option to always render html in repos. I am willing to add this feature myself.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/41023445-add-server-config-option-for-always-rendering-html-code?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

[tboerger]

Are you talking about a feature like #302?

[pgaskin]

Not exactly

[pgaskin]

More like allowing rendering of files in the repo.

[tboerger]

Can you explain the use case for that? I don't get it yet ;)

[pgaskin]

I have repository with HTML templates. I would like to preview them easily without them being in a separate location. I trust all users with write access to the server, so I want to simplify things by allowing rendering it right out of the repository.

[pgaskin]

Something like changing the ServeData function in routers/repo/download.go to this:

func ServeData(ctx *context.Context, name string, reader io.Reader) error {
	buf := make([]byte, 1024)
	n, _ := reader.Read(buf)
	if n > 0 {
		buf = buf[:n]
	}

	ctx.Resp.Header().Set("Cache-Control", "public,max-age=86400")

	// Google Chrome dislike commas in filenames, so let's change it to a space
	name = strings.Replace(name, ",", " ", -1)

        if setting.Repository.AlwaysRenderRawFiles {
		ctx.Resp.Header().Set("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, name))
	} else if base.IsTextFile(buf) || ctx.QueryBool("render") {
		ctx.Resp.Header().Set("Content-Type", "text/plain; charset=utf-8")
	} else if base.IsImageFile(buf) || base.IsPDFFile(buf) {
		ctx.Resp.Header().Set("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, name))
	} else {
		ctx.Resp.Header().Set("Content-Disposition", fmt.Sprintf(`attachment; filename="%s"`, name))
	}

	ctx.Resp.Write(buf)
	_, err := io.Copy(ctx.Resp, reader)
	return err
}

The setting AlwaysRenderRawFiles would have to be added to setting.go with a default of false (for security)

[pgaskin]

I will open a PR

[pgaskin]

I have opened the PR, and it is ready. I have tested the feature myself too.

[tboerger]

What do others think about that? I don't really like the idea to render every document/file.