Fix type in unused constant name #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
bkcsoft
suggested changes
Nov 7, 2016
routers/repo/webhook.go
Outdated
| HOOKS base.TplName = "repo/settings/hooks" | ||
| HookNew base.TplName = "repo/settings/hook_new" | ||
| ORG_HookNew base.TplName = "org/settings/hook_new" | ||
| Hooks base.TplName = "repo/settings/hooks" |
Member
There was a problem hiding this comment.
Convention seems to prefix templates with tpl :)
Member
Author
|
On Mon, Nov 07, 2016 at 10:58:37AM -0800, bkcsoft wrote:
Good point ! (and good convention) |
strk
added
lgtm/need 1
bkcsoft
approved these changes
Nov 7, 2016
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
tboerger
removed
the
lgtm/need 1
tboerger
added
the
lgtm/done
ethantkoenig
pushed a commit
to ethantkoenig/gitea
that referenced
this pull request
May 30, 2017
…tea#111) * Remove Name/Email from commit messagse in Scrub Tool Fixes due to code review * Updated testing of JSON scrub * Returns peacefully if json file does not exist * No json files test should not return error * Update to scrub_test
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.